From mboxrd@z Thu Jan 1 00:00:00 1970 From: Xiao Guangrong Subject: Re: [Qemu-devel] [PATCH v2 07/18] nvdimm: reserve address range for NVDIMM Date: Wed, 26 Aug 2015 17:40:12 +0800 Message-ID: <55DD897C.4030904@linux.intel.com> References: <1439563931-12352-1-git-send-email-guangrong.xiao@linux.intel.com> <1439563931-12352-8-git-send-email-guangrong.xiao@linux.intel.com> <20150825151247.GB8344@stefanha-thinkpad.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: ehabkost@redhat.com, kvm@vger.kernel.org, mst@redhat.com, gleb@kernel.org, mtosatti@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, imammedo@redhat.com, pbonzini@redhat.com, rth@twiddle.net To: Stefan Hajnoczi Return-path: Received: from mga02.intel.com ([134.134.136.20]:9681 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753566AbbHZJqB (ORCPT ); Wed, 26 Aug 2015 05:46:01 -0400 In-Reply-To: <20150825151247.GB8344@stefanha-thinkpad.redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 08/25/2015 11:12 PM, Stefan Hajnoczi wrote: > On Fri, Aug 14, 2015 at 10:52:00PM +0800, Xiao Guangrong wrote: >> diff --git a/hw/mem/nvdimm/pc-nvdimm.c b/hw/mem/nvdimm/pc-nvdimm.c >> index a53d235..7a270a8 100644 >> --- a/hw/mem/nvdimm/pc-nvdimm.c >> +++ b/hw/mem/nvdimm/pc-nvdimm.c >> @@ -24,6 +24,19 @@ >> >> #include "hw/mem/pc-nvdimm.h" >> >> +#define PAGE_SIZE (1UL << 12) > > This macro name is likely to collide with system headers or other code. > > Could you use the existing TARGET_PAGE_SIZE constant instead? > Will follow your way in the next version. Thank you for pointing it out.