From mboxrd@z Thu Jan  1 00:00:00 1970
From: Xiao Guangrong <guangrong.xiao@linux.intel.com>
Subject: Re: [PATCH v2 07/18] nvdimm: reserve address range for NVDIMM
Date: Mon, 31 Aug 2015 15:01:05 +0800
Message-ID: <55E3FBB1.2040202@linux.intel.com>
References: <1439563931-12352-1-git-send-email-guangrong.xiao@linux.intel.com>
 <1439563931-12352-8-git-send-email-guangrong.xiao@linux.intel.com>
 <20150828172509.GI3819@thinpad.lan.raisama.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: pbonzini@redhat.com, imammedo@redhat.com, gleb@kernel.org,
	mtosatti@redhat.com, stefanha@redhat.com, mst@redhat.com,
	rth@twiddle.net, kvm@vger.kernel.org, qemu-devel@nongnu.org
To: Eduardo Habkost <ehabkost@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mga01.intel.com ([192.55.52.88]:12098 "EHLO mga01.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751256AbbHaHHC (ORCPT <rfc822;kvm@vger.kernel.org>);
	Mon, 31 Aug 2015 03:07:02 -0400
In-Reply-To: <20150828172509.GI3819@thinpad.lan.raisama.net>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>


Hi Eduardo,

Thank you for reviewing my patches.

On 08/29/2015 01:25 AM, Eduardo Habkost wrote:
> On Fri, Aug 14, 2015 at 10:52:00PM +0800, Xiao Guangrong wrote:
>> NVDIMM reserves all the free range above 4G to do:
>> - Persistent Memory (PMEM) mapping
>> - implement NVDIMM ACPI device _DSM method
>>
>> Signed-off-by: Xiao Guangrong <guangrong.xiao@linux.intel.com>
> [...]
>> @@ -1302,6 +1303,7 @@ FWCfgState *pc_memory_init(MachineState *machine,
>>       MemoryRegion *ram_below_4g, *ram_above_4g;
>>       FWCfgState *fw_cfg;
>>       PCMachineState *pcms = PC_MACHINE(machine);
>> +    ram_addr_t offset;
>
> "offset" is a very generic name. I suggest naming it "nvdimm_offset".

'offset' is used for generic proposal as it is not only used for nvdimm but
also for calculating hotplug_mem_base:
       pcms->hotplug_memory.base = ROUND_UP(offset, 1ULL << 30);