From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Huth Subject: Re: [PATCH] KVM: ppc: Fix size of the PSPB register Date: Wed, 2 Sep 2015 09:16:21 +0200 Message-ID: <55E6A245.2050108@redhat.com> References: <1441143678-14295-1-git-send-email-thuth@redhat.com> <20150901222434.GA23007@fergus.ozlabs.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Cc: kvm-ppc@vger.kernel.org, Alexander Graf , kvm@vger.kernel.org, linuxppc-dev@lists.ozlabs.org To: Paul Mackerras Return-path: Received: from mx1.redhat.com ([209.132.183.28]:58266 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751976AbbIBHQ1 (ORCPT ); Wed, 2 Sep 2015 03:16:27 -0400 In-Reply-To: <20150901222434.GA23007@fergus.ozlabs.ibm.com> Sender: kvm-owner@vger.kernel.org List-ID: On 02/09/15 00:24, Paul Mackerras wrote: > On Tue, Sep 01, 2015 at 11:41:18PM +0200, Thomas Huth wrote: >> The size of the Problem State Priority Boost Register is only >> 32 bits, so let's change the type of the corresponding variable >> accordingly to avoid future trouble. > > Since we're already using lwz/stw in the assembly code in > book3s_hv_rmhandlers.S, this is actually a bug fix, isn't it? > How did you find it? Did you observe a failure of some kind, or did > you just find it by code inspection? Code inspection. I was looking for similar problems like the issue with the XER register that we've hit recently (https://patchwork.ozlabs.org/patch/476872/) while I was trying to debug a similar problem. Thomas