From mboxrd@z Thu Jan 1 00:00:00 1970 From: Xiao Guangrong Subject: Re: [PATCH v2 04/18] acpi: add aml_sizeof Date: Wed, 2 Sep 2015 18:39:34 +0800 Message-ID: <55E6D1E6.6070001@linux.intel.com> References: <1439563931-12352-1-git-send-email-guangrong.xiao@linux.intel.com> <1439563931-12352-5-git-send-email-guangrong.xiao@linux.intel.com> <20150902121852.584bc410@nial.brq.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: pbonzini@redhat.com, gleb@kernel.org, mtosatti@redhat.com, stefanha@redhat.com, mst@redhat.com, rth@twiddle.net, ehabkost@redhat.com, kvm@vger.kernel.org, qemu-devel@nongnu.org To: Igor Mammedov Return-path: Received: from mga02.intel.com ([134.134.136.20]:53774 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752682AbbIBKph (ORCPT ); Wed, 2 Sep 2015 06:45:37 -0400 In-Reply-To: <20150902121852.584bc410@nial.brq.redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 09/02/2015 06:18 PM, Igor Mammedov wrote: > On Fri, 14 Aug 2015 22:51:57 +0800 > Xiao Guangrong wrote: > >> Implement SizeOf term which is used by NVDIMM _DSM method in later patch >> >> Signed-off-by: Xiao Guangrong >> --- >> hw/acpi/aml-build.c | 8 ++++++++ >> include/hw/acpi/aml-build.h | 1 + >> 2 files changed, 9 insertions(+) >> >> diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c >> index 9e89efc..a526eed 100644 >> --- a/hw/acpi/aml-build.c >> +++ b/hw/acpi/aml-build.c >> @@ -1143,6 +1143,14 @@ Aml *aml_derefof(Aml *arg) >> return var; >> } >> >> +/* ACPI 6.0: 20.2.5.4 Type 2 Opcodes Encoding: DefSizeOf */ > ditto, refer to to the first revision where it's appeared > Good to me, will do. :)