From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Auger Subject: Re: [PATCH 5/9] arm/arm64: KVM: Use appropriate define in VGIC reset code Date: Fri, 4 Sep 2015 18:08:30 +0200 Message-ID: <55E9C1FE.6030809@linaro.org> References: <1440942866-23802-1-git-send-email-christoffer.dall@linaro.org> <1440942866-23802-6-git-send-email-christoffer.dall@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit To: Christoffer Dall , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org Return-path: Received: from mail-wi0-f180.google.com ([209.85.212.180]:35528 "EHLO mail-wi0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759024AbbIDQJX (ORCPT ); Fri, 4 Sep 2015 12:09:23 -0400 Received: by wicge5 with SMTP id ge5so22481988wic.0 for ; Fri, 04 Sep 2015 09:09:22 -0700 (PDT) In-Reply-To: <1440942866-23802-6-git-send-email-christoffer.dall@linaro.org> Sender: kvm-owner@vger.kernel.org List-ID: On 08/30/2015 03:54 PM, Christoffer Dall wrote: > We currently initialize the SGIs to be enabled in the VGIC code, but we > use the VGIC_NR_PPIS define for this purpose, instead of the the more s/the// Eric > natural VGIC_NR_SGIS. Change this slightly confusing use of the > defines. > > Note: This should have no functional change, as both names are defined > to the number 16. > > Signed-off-by: Christoffer Dall > --- > virt/kvm/arm/vgic.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/virt/kvm/arm/vgic.c b/virt/kvm/arm/vgic.c > index 0ba92d3..8299c24 100644 > --- a/virt/kvm/arm/vgic.c > +++ b/virt/kvm/arm/vgic.c > @@ -2099,7 +2099,7 @@ int vgic_init(struct kvm *kvm) > } > > for (i = 0; i < dist->nr_irqs; i++) { > - if (i < VGIC_NR_PPIS) > + if (i < VGIC_NR_SGIS) > vgic_bitmap_set_irq_val(&dist->irq_enabled, > vcpu->vcpu_id, i, 1); > if (i < VGIC_NR_PRIVATE_IRQS) >