From: Paolo Bonzini <pbonzini@redhat.com>
To: Alexander Kuleshov <kuleshovmail@gmail.com>,
Gleb Natapov <gleb@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kvm: compile process_smi_save_seg_64() only for x86_64
Date: Sun, 6 Sep 2015 16:22:32 +0200 [thread overview]
Message-ID: <55EC4C28.6070705@redhat.com> (raw)
In-Reply-To: <1441546541-20849-1-git-send-email-kuleshovmail@gmail.com>
On 06/09/2015 15:35, Alexander Kuleshov wrote:
> The process_smi_save_seg_64() function called only in the
> process_smi_save_state_64() if the CONFIG_X86_64 is set. This
> patch adds #ifdef CONFIG_X86_64 around process_smi_save_seg_64()
> to prevent following warning message:
>
> arch/x86/kvm/x86.c:5946:13: warning: ‘process_smi_save_seg_64’ defined but not used [-Wunused-function]
> static void process_smi_save_seg_64(struct kvm_vcpu *vcpu, char *buf, int n)
> ^
>
> Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
> ---
> arch/x86/kvm/x86.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
> index 1e7e76e..a60bdbc 100644
> --- a/arch/x86/kvm/x86.c
> +++ b/arch/x86/kvm/x86.c
> @@ -5943,6 +5943,7 @@ static void process_smi_save_seg_32(struct kvm_vcpu *vcpu, char *buf, int n)
> put_smstate(u32, buf, offset, process_smi_get_segment_flags(&seg));
> }
>
> +#ifdef CONFIG_X86_64
> static void process_smi_save_seg_64(struct kvm_vcpu *vcpu, char *buf, int n)
> {
> struct kvm_segment seg;
> @@ -5958,6 +5959,7 @@ static void process_smi_save_seg_64(struct kvm_vcpu *vcpu, char *buf, int n)
> put_smstate(u32, buf, offset + 4, seg.limit);
> put_smstate(u64, buf, offset + 8, seg.base);
> }
> +#endif
>
> static void process_smi_save_state_32(struct kvm_vcpu *vcpu, char *buf)
> {
>
Applied, thanks.
Paolo
prev parent reply other threads:[~2015-09-06 14:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-06 13:35 [PATCH] kvm: compile process_smi_save_seg_64() only for x86_64 Alexander Kuleshov
2015-09-06 14:22 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55EC4C28.6070705@redhat.com \
--to=pbonzini@redhat.com \
--cc=gleb@kernel.org \
--cc=hpa@zytor.com \
--cc=kuleshovmail@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).