From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH 6/9] KVM: VMX: simplify invpcid handling in
 vmx_cpuid_update()
Date: Mon, 7 Sep 2015 13:28:18 +0200
Message-ID: <55ED74D2.3010008@redhat.com>
References: <1440132611-26052-1-git-send-email-guangrong.xiao@linux.intel.com>
 <1440132611-26052-7-git-send-email-guangrong.xiao@linux.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Cc: gleb@kernel.org, mtosatti@redhat.com, kvm@vger.kernel.org,
	linux-kernel@vger.kernel.org
To: Xiao Guangrong <guangrong.xiao@linux.intel.com>
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <1440132611-26052-7-git-send-email-guangrong.xiao@linux.intel.com>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: kvm.vger.kernel.org



On 21/08/2015 06:50, Xiao Guangrong wrote:
> +	if (vmx_invpcid_supported() && (!best ||

Please start the "(" subexpression on a new line.

Paolo

> +	    !(best->ebx & bit(X86_FEATURE_INVPCID)) ||
> +	    !guest_cpuid_has_pcid(vcpu))) {