From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH 1/5] KVM: nVMX: refactor segment checks, make the code more clean and straightforward Date: Mon, 7 Sep 2015 13:37:44 +0200 Message-ID: <55ED7708.7030100@redhat.com> References: <20150820193625.GA3521@unote> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit To: Eugene Korenevsky , kvm@vger.kernel.org Return-path: Received: from mx1.redhat.com ([209.132.183.28]:52592 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751069AbbIGLhr (ORCPT ); Mon, 7 Sep 2015 07:37:47 -0400 In-Reply-To: <20150820193625.GA3521@unote> Sender: kvm-owner@vger.kernel.org List-ID: On 20/08/2015 21:36, Eugene Korenevsky wrote: > Prepare for subsequent changes. Extract calls for segment checking in protected > and 64-bit mode. This should be done to avoid overbloating of > get_vmx_mem_address() function, even if kvm_queue_exception_e() is called > twice. The idea behind the patch is okay, but all VMX root-mode instructions require CR0.PE = 1, so vmx_protmode_seg_check must always be run. Please adjust nested_vmx_check_permission to check CR0.PE as well. Paolo