From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH] kvm: irqchip: fix memory leak
Date: Mon, 7 Sep 2015 22:06:18 +0200
Message-ID: <55EDEE3A.1030700@redhat.com>
References: <1441177433-20225-1-git-send-email-sudipm.mukherjee@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
	Gleb Natapov <gleb@kernel.org>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:49548 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752600AbbIGUGW (ORCPT <rfc822;kvm@vger.kernel.org>);
	Mon, 7 Sep 2015 16:06:22 -0400
In-Reply-To: <1441177433-20225-1-git-send-email-sudipm.mukherjee@gmail.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>



On 02/09/2015 09:03, Sudip Mukherjee wrote:
> We were taking the exit path after checking ue->flags and return value
> of setup_routing_entry(), but 'e' was not freed incase of a failure.
> 
> Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
> ---
>  virt/kvm/irqchip.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/virt/kvm/irqchip.c b/virt/kvm/irqchip.c
> index 21c1424..c63e54f 100644
> --- a/virt/kvm/irqchip.c
> +++ b/virt/kvm/irqchip.c
> @@ -213,11 +213,15 @@ int kvm_set_irq_routing(struct kvm *kvm,
>  			goto out;
>  
>  		r = -EINVAL;
> -		if (ue->flags)
> +		if (ue->flags) {
> +			kfree(e);
>  			goto out;
> +		}
>  		r = setup_routing_entry(new, e, ue);
> -		if (r)
> +		if (r) {
> +			kfree(e);
>  			goto out;
> +		}
>  		++ue;
>  	}
>  
> 

Queued, thanks.

Paolo