From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH 8/9] KVM: VMX: introduce set_clear_2nd_exec_ctrl()
Date: Tue, 8 Sep 2015 22:32:28 +0200
Message-ID: <55EF45DC.9030401@redhat.com>
References: <1440132611-26052-1-git-send-email-guangrong.xiao@linux.intel.com>
 <1440132611-26052-9-git-send-email-guangrong.xiao@linux.intel.com>
 <55ED74B3.3070202@redhat.com> <55EEEF81.2000502@linux.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: QUOTED-PRINTABLE
Cc: gleb@kernel.org, mtosatti@redhat.com, kvm@vger.kernel.org,
	linux-kernel@vger.kernel.org
To: Xiao Guangrong <guangrong.xiao@linux.intel.com>
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <55EEEF81.2000502@linux.intel.com>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: kvm.vger.kernel.org



On 08/09/2015 16:24, Xiao Guangrong wrote:
>>
>> The second argument is always true.
>=20
> No...
>=20
> There are 3 places calling this function with set=3Dfalse=EF=BC=9A
> nested_release_vmcs12(), vmx_disable_pml() and
> vmx_cpuid_update()

You're right.  It's always constant---I don't know why I wrote it's
always true, and then suggested vmcs_clear32...

Paolo