From: Paolo Bonzini <pbonzini-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Feng Wu <feng.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
alex.williamson-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org,
mtosatti-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org
Cc: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
eric.auger-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org
Subject: Re: [PATCH v8 09/13] KVM: Add an arch specific hooks in 'struct kvm_kernel_irqfd'
Date: Wed, 16 Sep 2015 11:27:05 +0200 [thread overview]
Message-ID: <55F935E9.6070707@redhat.com> (raw)
In-Reply-To: <1442393409-2623-10-git-send-email-feng.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
On 16/09/2015 10:50, Feng Wu wrote:
> +int kvm_arch_update_irqfd_routing(struct kvm *kvm, unsigned int host_irq,
> + uint32_t guest_irq, bool set)
> +{
> + return !kvm_x86_ops->update_pi_irte ? -EINVAL :
> + kvm_x86_ops->update_pi_irte(kvm, host_irq, guest_irq, set);
> +}
> +
Just use "if" here. No need to resend if this is the only comment.
>
> }
> +int __attribute__((weak)) kvm_arch_update_irqfd_routing(
> + struct kvm *kvm, unsigned
Empty line after "}".
Paolo
next prev parent reply other threads:[~2015-09-16 9:27 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-16 8:49 [PATCH v8 00/13] Add VT-d Posted-Interrupts support Feng Wu
[not found] ` <1442393409-2623-1-git-send-email-feng.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-09-16 8:49 ` [PATCH v8 01/13] KVM: Extend struct pi_desc for VT-d Posted-Interrupts Feng Wu
2015-09-16 8:49 ` [PATCH v8 02/13] KVM: Add some helper functions for Posted-Interrupts Feng Wu
2015-09-16 8:49 ` [PATCH v8 03/13] KVM: Define a new interface kvm_intr_is_single_vcpu() Feng Wu
[not found] ` <1442393409-2623-4-git-send-email-feng.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-09-16 9:23 ` Paolo Bonzini
[not found] ` <55F934F5.7040605-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-09-17 3:17 ` Wu, Feng
2015-09-17 9:42 ` Paolo Bonzini
[not found] ` <55FA8AED.6090700-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-09-17 13:36 ` Wu, Feng
[not found] ` <E959C4978C3B6342920538CF579893F002718968-0J0gbvR4kTg/UvCtAeCM4rfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2015-09-17 14:24 ` Paolo Bonzini
2015-09-17 15:58 ` Radim Krčmář
[not found] ` <20150917155821.GB2573-KfRq7+sF/6zkZJWtSm8s3NvLeJWuRmrY@public.gmane.org>
2015-09-17 16:00 ` Paolo Bonzini
[not found] ` <55FAE395.4000008-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-09-17 23:18 ` Wu, Feng
[not found] ` <E959C4978C3B6342920538CF579893F00271A691-0J0gbvR4kTg/UvCtAeCM4rfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2015-09-18 16:16 ` Radim Krčmář
[not found] ` <20150918161631.GA27908-KfRq7+sF/6zkZJWtSm8s3NvLeJWuRmrY@public.gmane.org>
2015-09-18 16:17 ` Paolo Bonzini
[not found] ` <55FACD35.1030602-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-09-17 23:15 ` Wu, Feng
2015-09-16 8:50 ` [PATCH v8 04/13] KVM: Make struct kvm_irq_routing_table accessible Feng Wu
2015-09-16 8:50 ` [PATCH v8 05/13] KVM: make kvm_set_msi_irq() public Feng Wu
2015-09-16 8:50 ` [PATCH v8 06/13] vfio: Register/unregister irq_bypass_producer Feng Wu
2015-09-16 8:50 ` [PATCH v8 07/13] KVM: x86: Update IRTE for posted-interrupts Feng Wu
2015-09-16 8:50 ` [PATCH v8 08/13] KVM: Implement IRQ bypass consumer callbacks for x86 Feng Wu
2015-09-16 8:50 ` [PATCH v8 09/13] KVM: Add an arch specific hooks in 'struct kvm_kernel_irqfd' Feng Wu
[not found] ` <1442393409-2623-10-git-send-email-feng.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-09-16 9:27 ` Paolo Bonzini [this message]
[not found] ` <55F935E9.6070707-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-09-17 1:51 ` Wu, Feng
[not found] ` <E959C4978C3B6342920538CF579893F002716E32-0J0gbvR4kTg/UvCtAeCM4rfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2015-09-17 9:38 ` Paolo Bonzini
2015-09-16 8:50 ` [PATCH v8 10/13] KVM: Update Posted-Interrupts Descriptor when vCPU is preempted Feng Wu
[not found] ` <1442393409-2623-11-git-send-email-feng.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-09-16 9:29 ` Paolo Bonzini
2015-09-16 8:50 ` [PATCH v8 11/13] KVM: Update Posted-Interrupts Descriptor when vCPU is blocked Feng Wu
[not found] ` <1442393409-2623-12-git-send-email-feng.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-09-16 9:32 ` Paolo Bonzini
2015-09-16 8:50 ` [PATCH v8 12/13] KVM: Warn if 'SN' is set during posting interrupts by software Feng Wu
[not found] ` <1442393409-2623-13-git-send-email-feng.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-09-16 9:32 ` Paolo Bonzini
2015-09-16 8:50 ` [PATCH v8 13/13] iommu/vt-d: Add a command line parameter for VT-d posted-interrupts Feng Wu
2015-09-16 9:34 ` [PATCH v8 00/13] Add VT-d Posted-Interrupts support Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55F935E9.6070707@redhat.com \
--to=pbonzini-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
--cc=alex.williamson-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=eric.auger-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=feng.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org \
--cc=kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mtosatti-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).