From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH v8 09/13] KVM: Add an arch specific hooks in 'struct kvm_kernel_irqfd' Date: Thu, 17 Sep 2015 11:38:49 +0200 Message-ID: <55FA8A29.7030905@redhat.com> References: <1442393409-2623-1-git-send-email-feng.wu@intel.com> <1442393409-2623-10-git-send-email-feng.wu@intel.com> <55F935E9.6070707@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: "iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "eric.auger-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org" To: "Wu, Feng" , "alex.williamson-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org" , "joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org" , "mtosatti-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org" Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org List-Id: kvm.vger.kernel.org On 17/09/2015 03:51, Wu, Feng wrote: > > >> -----Original Message----- >> From: Paolo Bonzini [mailto:pbonzini-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org] >> Sent: Wednesday, September 16, 2015 5:27 PM >> To: Wu, Feng; alex.williamson-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org; joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org; >> mtosatti-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org >> Cc: eric.auger-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org; kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; >> iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org; linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org >> Subject: Re: [PATCH v8 09/13] KVM: Add an arch specific hooks in 'struct >> kvm_kernel_irqfd' >> >> >> >> On 16/09/2015 10:50, Feng Wu wrote: >>> +int kvm_arch_update_irqfd_routing(struct kvm *kvm, unsigned int host_irq, >>> + uint32_t guest_irq, bool set) >>> +{ >>> + return !kvm_x86_ops->update_pi_irte ? -EINVAL : >>> + kvm_x86_ops->update_pi_irte(kvm, host_irq, guest_irq, set); >>> +} >>> + >> >> Just use "if" here. No need to resend if this is the only comment. > > I am sorry, I don't quite understand. Do you mean I don't need to include > this patch in v9? If so, what about other patches with your Reviewed-by? No, I just wrote this email first. If this was the only comment, I could have fixed it up myself. But since there were a few other comments, please send v9 with all the required changes. Thanks, Paolo