From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Denis V. Lunev" <den@openvz.org>
Subject: Re: [kvm:queue 27/38] arch/x86/kvm/hyperv.c:186:41: sparse: incorrect
 type in argument 2 (different modifiers)
Date: Fri, 18 Sep 2015 16:57:39 +0300
Message-ID: <55FC1853.6090308@openvz.org>
References: <201509182109.6ccgXDVp%fengguang.wu@intel.com>
 <55FC16F4.7060407@openvz.org> <55FC17B4.9060702@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Cc: <kbuild-all@01.org>, Roman Kagan <rkagan@virtuozzo.com>,
	<kvm@vger.kernel.org>
To: Paolo Bonzini <pbonzini@redhat.com>,
	kbuild test robot <fengguang.wu@intel.com>,
	Andrey Smetanin <asmetanin@virtuozzo.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from relay.parallels.com ([195.214.232.42]:47554 "EHLO
	relay.parallels.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753708AbbIRN54 (ORCPT <rfc822;kvm@vger.kernel.org>);
	Fri, 18 Sep 2015 09:57:56 -0400
In-Reply-To: <55FC17B4.9060702@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On 09/18/2015 04:55 PM, Paolo Bonzini wrote:
>
> On 18/09/2015 15:51, Denis V. Lunev wrote:
>>>      185
>>>    > 186        task_cputime_adjusted(current, &utime, &stime);
>>>      187        return div_u64(cputime_to_nsecs(utime + stime), 100);
>>>      188    }
>>>      189
>>>      190    static int kvm_hv_set_msr(struct kvm_vcpu *vcpu, u32 msr,
>>> u64 data, bool host)
>>>      191    {
>>>      192        struct kvm_vcpu_hv *hv = &vcpu->arch.hyperv;
>>>      193
>>>      194        switch (msr) {
>>>
>>> ---
>>> 0-DAY kernel test infrastructure                Open Source Technology
>>> Center
>>> https://lists.01.org/pipermail/kbuild-all                   Intel
>>> Corporation
>> can not get an idea what is this warning about...
>> For me it looks pretty lame.
> I think it wants you to do
>
> -	return div_u64(cputime_to_nsecs(utime + stime), 100);
> +	return div_u64(cputime_to_nsecs(utime) +
> +		       cputime_to_nsecs(stime), 100);
>
> Paolo
ok, I'll check but warning points here

   > 186        task_cputime_adjusted(current, &utime, &stime);

and says about parameters 2 and 3. There is no parameter 3
in div_u64 call :)