From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH] KVM: x86: fix bogus warning about reserved bits Date: Wed, 23 Sep 2015 14:50:37 +0200 Message-ID: <5602A01D.1020006@redhat.com> References: <1442910329-3357-1-git-send-email-pbonzini@redhat.com> <20150922175647.GC3568@pd.tnic> <5601C266.4060601@redhat.com> <20150923075635.GA3564@pd.tnic> <560272AF.40802@redhat.com> <20150923110733.GA3528@pd.tnic> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org To: Borislav Petkov Return-path: In-Reply-To: <20150923110733.GA3528@pd.tnic> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On 23/09/2015 13:07, Borislav Petkov wrote: >> > + static bool first; >> > >> > best = kvm_find_cpuid_entry(vcpu, 0, 0); >> > + if (first && best) { >> > + printk("cpuid(0).ebx = %x\n", best->ebx); >> > + first = false; >> > + } else if (first) >> > + printk_ratelimited("cpuid(0) not initialized yet\n"); >> > + >> > return best && best->ebx == X86EMUL_CPUID_VENDOR_AuthenticAMD_ebx; > Do I see it correctly that that "first" thing is never true? > > In any case, I changed it to initialize to true but still no output from > that function. > > [ 102.448438] walk_shadow_page_get_mmio_spte: detect reserved bits on spte, addr 0xb8000 (level 4, 0xf0000000000f8) > [ 102.458706] walk_shadow_page_get_mmio_spte: detect reserved bits on spte, addr 0xb8000 (level 3, 0xf000000000078) > [ 102.468955] walk_shadow_page_get_mmio_spte: detect reserved bits on spte, addr 0xb8000 (level 2, 0xf000000000078) Yeah, but I didn't totally need the output so I didn't bother answering with yet another v2. I'm a bit stymied and will try to find an AMD machine inside RH (it's always a pain to install latest-and-greatest kernel on unknown machines). It's probably also time to buy one too... Paolo