From: Paolo Bonzini <pbonzini@redhat.com>
To: Borislav Petkov <bp@alien8.de>,
Xiao Guangrong <guangrong.xiao@linux.intel.com>
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: [PATCH] KVM: x86: fix bogus warning about reserved bits
Date: Fri, 25 Sep 2015 09:49:42 +0200 [thread overview]
Message-ID: <5604FC96.1010707@redhat.com> (raw)
In-Reply-To: <20150924101227.GA3774@pd.tnic>
On 24/09/2015 12:12, Borislav Petkov wrote:
> On Thu, Sep 24, 2015 at 11:23:08AM +0800, Xiao Guangrong wrote:
>>> +static inline bool
>>> +boot_cpu_is_amd(void)
>>> +{
>>> + WARN_ON_ONCE(!tdp_enabled);
>>> + return shadow_x_mask != 0;
>>
>> shadow_x_mask != 0 is Intel's CPU.
>>
>> Borislav, could you please check shadow_x_mask == 0 instead and test it again?
>
> That did the trick:
>
> [ 62.640392] kvm: zapping shadow pages for mmio generation wraparound
> [ 63.100301] cpuid(0).ebx = 68747541
> [ 63.193426] kvm [3748]: vcpu0 unhandled rdmsr: 0xc0010112
> [ 64.538294] kvm [3748]: vcpu0 unhandled rdmsr: 0xc0011021
> [ 64.866263] kvm [3748]: vcpu1 unhandled rdmsr: 0xc0011021
> [ 64.971972] kvm [3748]: vcpu2 unhandled rdmsr: 0xc0011021
> [ 65.070376] kvm [3748]: vcpu3 unhandled rdmsr: 0xc0011021
> [ 65.170625] kvm [3748]: vcpu4 unhandled rdmsr: 0xc0011021
> [ 65.272838] kvm [3748]: vcpu5 unhandled rdmsr: 0xc0011021
> [ 65.374288] kvm [3748]: vcpu6 unhandled rdmsr: 0xc0011021
> [ 65.474825] kvm [3748]: vcpu7 unhandled rdmsr: 0xc0011021
>
> That's all I got in dmesg from booting the guest - no more mmio PF
> warnings.
Great, though this doesn't yet explain why guest_cpuid_is_amd failed.
I'll look into it next week when Amazon delivers my shiny new AMD
mini-PC :) and send the patch to Linus meanwhile.
Paolo
next prev parent reply other threads:[~2015-09-25 7:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-22 8:25 [PATCH] KVM: x86: fix bogus warning about reserved bits Paolo Bonzini
2015-09-22 17:56 ` Borislav Petkov
2015-09-22 21:04 ` Paolo Bonzini
2015-09-23 7:56 ` Borislav Petkov
2015-09-23 8:34 ` Paolo Bonzini
2015-09-23 9:36 ` Paolo Bonzini
2015-09-23 11:07 ` Borislav Petkov
2015-09-23 12:50 ` Paolo Bonzini
2015-09-24 3:23 ` Xiao Guangrong
2015-09-24 10:12 ` Borislav Petkov
2015-09-25 7:49 ` Paolo Bonzini [this message]
2015-09-28 3:16 ` Xiao Guangrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5604FC96.1010707@redhat.com \
--to=pbonzini@redhat.com \
--cc=bp@alien8.de \
--cc=guangrong.xiao@linux.intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).