From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 3/3] Target-ppc: Remove unnecessary variable
Date: Mon, 28 Sep 2015 12:56:04 +0200
Message-ID: <56091CC4.4020108@redhat.com>
References: <1443170278-9318-1-git-send-email-shraddha.6596@gmail.com>
 <1443170278-9318-3-git-send-email-shraddha.6596@gmail.com>
 <5606C4A1.60509@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: qemu-devel <qemu-devel@nongnu.org>
To: Eric Blake <eblake@redhat.com>,
	Shraddha Barke <shraddha.6596@gmail.com>, kvm@vger.kernel.org,
	qemu-trivial@nongnu.org, Michael Tokarev <mjt@tls.msk.ru>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:45656 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S932631AbbI1K4M (ORCPT <rfc822;kvm@vger.kernel.org>);
	Mon, 28 Sep 2015 06:56:12 -0400
In-Reply-To: <5606C4A1.60509@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>



On 26/09/2015 18:15, Eric Blake wrote:
> On 09/25/2015 02:37 AM, Shraddha Barke wrote:
>> Compress lines and remove the variable.
>>
> 
>> +++ b/target-ppc/kvm.c
>> @@ -1782,8 +1782,7 @@ uint32_t kvmppc_get_tbfreq(void)
>>  
>>      ns++;
>>  
>> -    retval = atoi(ns);
>> -    return retval;
>> +    return atoi(ns);
> 
> atoi() is lousy; it cannot properly detect user input errors.  This
> should probably be converted to use the appropriate qemu_strtol variant
> instead.

But it's more or less okay here, it's parsing /proc/cpuinfo.

Paolo