From: "Dirk Müller" <dmueller@suse.com>
To: kvm@vger.kernel.org
Cc: Joerg Roedel <joro@8bytes.org>
Subject: [PATCH] Use WARN_ON_ONCE for missing X86_FEATURE_NRIPS
Date: Thu, 1 Oct 2015 13:43:42 +0200 [thread overview]
Message-ID: <560D1C6E.2060803@suse.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 294 bytes --]
The cpu feature flags are not ever going to change, so warning
everytime can cause a lot of kernel log spam
(in our case more than 10GB/hour).
Signed-off-by: Dirk Mueller <dmueller@suse.com>
--
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton,
HRB 21284 (AG Nürnberg)
[-- Attachment #2: 0001-Use-WARN_ON_ONCE-for-missing-X86_FEATURE_NRIPS.patch --]
[-- Type: text/x-patch, Size: 943 bytes --]
>From 40c7213e34a1a1caf0b98db832c06c593f888b11 Mon Sep 17 00:00:00 2001
From: Dirk Mueller <dirk@dmllr.de>
Date: Thu, 1 Oct 2015 13:10:10 +0200
Subject: [PATCH] Use WARN_ON_ONCE for missing X86_FEATURE_NRIPS
The cpu feature flags are not ever going to change, so warning
everytime can cause a lot of kernel log spam
(in our case more than 10GB/hour).
Signed-off-by: Dirk Mueller <dmueller@suse.com>
---
arch/x86/kvm/svm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/kvm/svm.c b/arch/x86/kvm/svm.c
index 94b7d15..0a42859 100644
--- a/arch/x86/kvm/svm.c
+++ b/arch/x86/kvm/svm.c
@@ -514,7 +514,7 @@ static void skip_emulated_instruction(struct kvm_vcpu *vcpu)
struct vcpu_svm *svm = to_svm(vcpu);
if (svm->vmcb->control.next_rip != 0) {
- WARN_ON(!static_cpu_has(X86_FEATURE_NRIPS));
+ WARN_ON_ONCE(!static_cpu_has(X86_FEATURE_NRIPS));
svm->next_rip = svm->vmcb->control.next_rip;
}
--
2.5.1
next reply other threads:[~2015-10-01 11:44 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-01 11:43 Dirk Müller [this message]
2015-10-01 12:25 ` [PATCH] Use WARN_ON_ONCE for missing X86_FEATURE_NRIPS Paolo Bonzini
2015-10-01 12:45 ` Dirk Müller
2015-10-01 12:31 ` Paolo Bonzini
2015-10-01 22:31 ` Bandan Das
2015-10-02 6:43 ` Dirk Müller
2015-10-05 1:15 ` Bandan Das
2015-10-05 9:50 ` Joerg Roedel
2015-10-05 16:54 ` Bandan Das
2015-10-05 17:15 ` Joerg Roedel
2015-10-05 17:42 ` Bandan Das
2015-10-06 10:23 ` Joerg Roedel
2015-10-06 18:02 ` Bandan Das
2015-10-05 20:12 ` Dirk Müller
2015-10-05 22:00 ` Bandan Das
2015-10-06 10:28 ` Joerg Roedel
2015-10-06 17:59 ` Bandan Das
2015-10-07 11:03 ` Joerg Roedel
2015-10-07 12:47 ` [PATCH] kvm: svm: Only propagate next_rip when guest supports it Joerg Roedel
2015-10-07 12:57 ` kbuild test robot
2015-10-07 15:48 ` Bandan Das
2015-10-07 16:14 ` Joerg Roedel
2015-10-07 17:03 ` Dirk Müller
2015-10-07 14:58 ` [PATCH] Use WARN_ON_ONCE for missing X86_FEATURE_NRIPS Bandan Das
2015-10-07 15:24 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=560D1C6E.2060803@suse.com \
--to=dmueller@suse.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).