From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Dirk_M=c3=bcller?= Subject: [PATCH] Use WARN_ON_ONCE for missing X86_FEATURE_NRIPS Date: Thu, 1 Oct 2015 13:43:42 +0200 Message-ID: <560D1C6E.2060803@suse.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------060308080009030203050600" Cc: Joerg Roedel To: kvm@vger.kernel.org Return-path: Received: from smtp.nue.novell.com ([195.135.221.5]:49834 "EHLO smtp.nue.novell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756318AbbJALoC (ORCPT ); Thu, 1 Oct 2015 07:44:02 -0400 Sender: kvm-owner@vger.kernel.org List-ID: This is a multi-part message in MIME format. --------------060308080009030203050600 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit The cpu feature flags are not ever going to change, so warning everytime can cause a lot of kernel log spam (in our case more than 10GB/hour). Signed-off-by: Dirk Mueller -- SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg) --------------060308080009030203050600 Content-Type: text/x-patch; name="0001-Use-WARN_ON_ONCE-for-missing-X86_FEATURE_NRIPS.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename*0="0001-Use-WARN_ON_ONCE-for-missing-X86_FEATURE_NRIPS.patch" >>From 40c7213e34a1a1caf0b98db832c06c593f888b11 Mon Sep 17 00:00:00 2001 From: Dirk Mueller Date: Thu, 1 Oct 2015 13:10:10 +0200 Subject: [PATCH] Use WARN_ON_ONCE for missing X86_FEATURE_NRIPS The cpu feature flags are not ever going to change, so warning everytime can cause a lot of kernel log spam (in our case more than 10GB/hour). Signed-off-by: Dirk Mueller --- arch/x86/kvm/svm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/kvm/svm.c b/arch/x86/kvm/svm.c index 94b7d15..0a42859 100644 --- a/arch/x86/kvm/svm.c +++ b/arch/x86/kvm/svm.c @@ -514,7 +514,7 @@ static void skip_emulated_instruction(struct kvm_vcpu *vcpu) struct vcpu_svm *svm = to_svm(vcpu); if (svm->vmcb->control.next_rip != 0) { - WARN_ON(!static_cpu_has(X86_FEATURE_NRIPS)); + WARN_ON_ONCE(!static_cpu_has(X86_FEATURE_NRIPS)); svm->next_rip = svm->vmcb->control.next_rip; } -- 2.5.1 --------------060308080009030203050600--