From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH 2/2] KVM: x86: fix edge EOI and IOAPIC reconfig race Date: Wed, 7 Oct 2015 11:29:32 +0200 Message-ID: <5614E5FC.7060207@redhat.com> References: <1439473570-13763-1-git-send-email-rkrcmar@redhat.com> <1439473570-13763-3-git-send-email-rkrcmar@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: kvm@vger.kernel.org, Steve Rutherford , stable@vger.kernel.org To: =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , linux-kernel@vger.kernel.org Return-path: In-Reply-To: <1439473570-13763-3-git-send-email-rkrcmar@redhat.com> Sender: stable-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On 13/08/2015 15:46, Radim Kr=C4=8Dm=C3=A1=C5=99 wrote: > + if (kvm_x86_ops->sync_pir_to_irr(vcpu)) > + kvm_make_request(KVM_REQ_EVENT, vcpu); > + The call to sync_pir_to_irr belongs more in vcpu_scan_ioapic, I think. More importantly, I think that KVM_REQ_EVENT is a latent bug for kvm_vcpu_ioctl_get_lapic as well, so the call to kvm_make_request shoul= d go in vmx_sync_pir_to_irr or in a new kvm_sync_pir_to_irr wrapper. > + (e->fields.trig_mode =3D=3D IOAPIC_EDGE_TRIG && > + kvm_apic_pending_eoi(vcpu, e->fields.vector))) Should we test again here that kvm_irq_has_notifier(ioapic->kvm, KVM_IRQCHIP_IOAPIC, index), to avoid unnecessarily marking other edge-triggered interrupts? Paolo