From mboxrd@z Thu Jan 1 00:00:00 1970 From: Xiao Guangrong Subject: Re: [PATCH v3 00/32] implement vNVDIMM Date: Tue, 13 Oct 2015 13:29:48 +0800 Message-ID: <561C96CC.40702@linux.intel.com> References: <1444535584-18220-1-git-send-email-guangrong.xiao@linux.intel.com> <20151012144113-mutt-send-email-mst@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: pbonzini@redhat.com, imammedo@redhat.com, gleb@kernel.org, mtosatti@redhat.com, stefanha@redhat.com, rth@twiddle.net, ehabkost@redhat.com, dan.j.williams@intel.com, kvm@vger.kernel.org, qemu-devel@nongnu.org To: "Michael S. Tsirkin" Return-path: Received: from mga11.intel.com ([192.55.52.93]:65106 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750926AbbJMFf7 (ORCPT ); Tue, 13 Oct 2015 01:35:59 -0400 In-Reply-To: <20151012144113-mutt-send-email-mst@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 10/12/2015 07:55 PM, Michael S. Tsirkin wrote: > On Sun, Oct 11, 2015 at 11:52:32AM +0800, Xiao Guangrong wrote: >> Changelog in v3: >> There is huge change in this version, thank Igor, Stefan, Paolo, Eduardo, >> Michael for their valuable comments, the patchset finally gets better shape. > > Thanks! > This needs some changes in coding style, and more comments, to > make it easier to maintain going forward. Thanks for your review, Michael. I have learned lots of thing from your comments. > > High level comments - I didn't point out all instances, > please go over code and locate them yourself. > I focused on acpi code in this review. Okay, will do. > > - fix coding style violations, prefix eveything with nvdimm_ etc Actually i did not pay attention on naming the stuff which is only internally used. Thank you for pointing it out and will fix it in next version. > - in apci code, avoid manual memory management/complex pointer math I am not very good at ACPI ASL/AML, could you please more detail? > - comments are needed to document apis & explain what's going on > - constants need comments too, refer to text that > can be looked up in acpi spec verbatim Indeed, will document carefully.