From mboxrd@z Thu Jan 1 00:00:00 1970 From: Xiao Guangrong Subject: Re: [PATCH v3 23/32] nvdimm: build ACPI NFIT table Date: Tue, 13 Oct 2015 14:06:08 +0800 Message-ID: <561C9F50.9040605@linux.intel.com> References: <1444535584-18220-1-git-send-email-guangrong.xiao@linux.intel.com> <1444535584-18220-24-git-send-email-guangrong.xiao@linux.intel.com> <20151012133853-mutt-send-email-mst@redhat.com> <561C92EE.60609@linux.intel.com> <20151013082734-mutt-send-email-mst@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: pbonzini@redhat.com, imammedo@redhat.com, gleb@kernel.org, mtosatti@redhat.com, stefanha@redhat.com, rth@twiddle.net, ehabkost@redhat.com, dan.j.williams@intel.com, kvm@vger.kernel.org, qemu-devel@nongnu.org To: "Michael S. Tsirkin" Return-path: Received: from mga02.intel.com ([134.134.136.20]:8776 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751968AbbJMGMU (ORCPT ); Tue, 13 Oct 2015 02:12:20 -0400 In-Reply-To: <20151013082734-mutt-send-email-mst@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 10/13/2015 01:42 PM, Michael S. Tsirkin wrote: > On Tue, Oct 13, 2015 at 01:13:18PM +0800, Xiao Guangrong wrote: >>> >>>> #endif >>> >>> This header is too small to be worth it. >>> nvdimm_get_built_list seems to be the only interface - >>> just stick it in the header you have under include. >>> >> >> Other functions are introudced and included into it in later patches, >> it includes the internal things shared between nvdimm device, nvdimm ACPI, >> nvdimm namespace. >> >> Furthermore, this is a internal include file, it is not bad i think. > > Each time we do this, this seems to invite abuse where > people add APIs without documenting them. > Understood. > I guess I could buy this if you add nvdimm_defs.h > with just internal things such as layout of the buffer > used for communication between ACPI and hardware. > Okay, i will rename internel.h to nvdimm_defs.h and carefully document everything (definitions, function prototypes, etc.) in this file. :)