From mboxrd@z Thu Jan 1 00:00:00 1970 From: Xiao Guangrong Subject: Re: [PATCH v3 03/32] acpi: add aml_create_field Date: Wed, 14 Oct 2015 00:36:25 +0800 Message-ID: <561D3309.5000300@linux.intel.com> References: <1444535584-18220-1-git-send-email-guangrong.xiao@linux.intel.com> <1444535584-18220-4-git-send-email-guangrong.xiao@linux.intel.com> <20151013143822.4a3ebc47@nial.brq.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: pbonzini@redhat.com, gleb@kernel.org, mtosatti@redhat.com, stefanha@redhat.com, mst@redhat.com, rth@twiddle.net, ehabkost@redhat.com, dan.j.williams@intel.com, kvm@vger.kernel.org, qemu-devel@nongnu.org To: Igor Mammedov Return-path: Received: from mga14.intel.com ([192.55.52.115]:30196 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753118AbbJMQmh (ORCPT ); Tue, 13 Oct 2015 12:42:37 -0400 In-Reply-To: <20151013143822.4a3ebc47@nial.brq.redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 10/13/2015 08:38 PM, Igor Mammedov wrote: > On Sun, 11 Oct 2015 11:52:35 +0800 > Xiao Guangrong wrote: > >> Implement CreateField term which is used by NVDIMM _DSM method in later patch >> >> Signed-off-by: Xiao Guangrong >> --- >> hw/acpi/aml-build.c | 13 +++++++++++++ >> include/hw/acpi/aml-build.h | 1 + >> 2 files changed, 14 insertions(+) >> >> diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c >> index a72214d..9fe5e7b 100644 >> --- a/hw/acpi/aml-build.c >> +++ b/hw/acpi/aml-build.c >> @@ -1151,6 +1151,19 @@ Aml *aml_sizeof(Aml *arg) >> return var; >> } >> >> +/* ACPI 1.0b: 16.2.5.2 Named Objects Encoding: DefCreateField */ >> +Aml *aml_create_field(Aml *srcbuf, Aml *index, Aml *len, const char *name) > you haven't addressed v2 comment wrt index, len > https://lists.gnu.org/archive/html/qemu-devel/2015-09/msg00435.html Ah, i forgot to mention that the index/len can be determined at runtime: aml_append(_method_, aml_create_field(aml_name("ODAT"), aml_int(0),\ aml_local(6) , "OBUF")); That why i kept these as "aml *" and sorry for i failed to log it in patch 0.