From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Huth Subject: Re: [PATCH] KVM: PPC: Implement extension to report number of memslots Date: Fri, 16 Oct 2015 08:41:31 +0200 Message-ID: <56209C1B.2060903@redhat.com> References: <1444971473-26514-1-git-send-email-nikunj@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, paulus@samba.org To: Nikunj A Dadhania , kvm-ppc@vger.kernel.org, agraf@suse.de Return-path: Received: from mx1.redhat.com ([209.132.183.28]:48072 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751578AbbJPGlf (ORCPT ); Fri, 16 Oct 2015 02:41:35 -0400 In-Reply-To: <1444971473-26514-1-git-send-email-nikunj@linux.vnet.ibm.com> Sender: kvm-owner@vger.kernel.org List-ID: On 16/10/15 06:57, Nikunj A Dadhania wrote: > QEMU assumes 32 memslots if this extension is not implemented. Although, > current value of KVM_USER_MEM_SLOTS is 32, once KVM_USER_MEM_SLOTS > changes QEMU would take a wrong value. > > Signed-off-by: Nikunj A Dadhania > --- > arch/powerpc/kvm/powerpc.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arch/powerpc/kvm/powerpc.c b/arch/powerpc/kvm/powerpc.c > index 2e51289..6fd2405 100644 > --- a/arch/powerpc/kvm/powerpc.c > +++ b/arch/powerpc/kvm/powerpc.c > @@ -559,6 +559,9 @@ int kvm_vm_ioctl_check_extension(struct kvm *kvm, long ext) > else > r = num_online_cpus(); > break; > + case KVM_CAP_NR_MEMSLOTS: > + r = KVM_USER_MEM_SLOTS; > + break; > case KVM_CAP_MAX_VCPUS: > r = KVM_MAX_VCPUS; > break; Yes, we'll likely need this soon! 32 slots are not enough... Reviewed-by: Thomas Huth