From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH 9/9] kvm/x86: Hyper-V kvm exit Date: Fri, 16 Oct 2015 09:51:58 +0200 Message-ID: <5620AC9E.4050905@redhat.com> References: <1444979273-6587-1-git-send-email-den@openvz.org> <1444979273-6587-10-git-send-email-den@openvz.org> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: rkagan@virtuozzo.com, virtualization@lists.linux-foundation.org, qemu-devel@nongnu.org, kvm@vger.kernel.org, Andrey Smetanin , Vitaly Kuznetsov , "K. Y. Srinivasan" , Gleb Natapov To: "Denis V. Lunev" Return-path: Received: from mail-lf0-f68.google.com ([209.85.215.68]:33118 "EHLO mail-lf0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751560AbbJPHwD (ORCPT ); Fri, 16 Oct 2015 03:52:03 -0400 Received: by lfaz124 with SMTP id z124so6892172lfa.0 for ; Fri, 16 Oct 2015 00:52:01 -0700 (PDT) In-Reply-To: <1444979273-6587-10-git-send-email-den@openvz.org> Sender: kvm-owner@vger.kernel.org List-ID: On 16/10/2015 09:07, Denis V. Lunev wrote: > > + /* KVM_EXIT_HYPERV */ > + struct kvm_hyperv_exit hyperv; > +Indicates that the VCPU exits into userspace to process some tasks > +related with Hyper-V emulation. Currently used to synchronize modified > +Hyper-V SynIC state with userspace. > + The documentation should include the definition of the struct and the definition of the subtypes (currently KVM_EXIT_HYPERV_SYNIC only). Documentation for KVM_CAP_HYPERV_SINIC and KVM_IRQ_ROUTING_HV_SINT is missing, too. Finally, it would be better to have unit tests in kvm-unit-tests. Either this or QEMU support is a requirement for merging, and the unit tests are probably easier. But apart from this, the series looks great and I'm already applying it to kvm/queue so that it gets some more testing. Paolo