From: Paolo Bonzini <pbonzini@redhat.com>
To: David Matlack <dmatlack@google.com>,
Marcelo Tosatti <mtosatti@redhat.com>
Cc: kvm list <kvm@vger.kernel.org>, Rik van Riel <riel@redhat.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
Amit Shah <amit.shah@redhat.com>
Subject: Re: [PATCH] KVM: x86: move steal time initialization to vcpu entry time
Date: Fri, 16 Oct 2015 10:34:54 +0200 [thread overview]
Message-ID: <5620B6AE.9020004@redhat.com> (raw)
In-Reply-To: <CALzav=fa+EJJpzWj9kQLbgG2Z9vKHqSfB==RhP0bvA5j2_QUMQ@mail.gmail.com>
On 15/10/2015 19:10, David Matlack wrote:
> > As reported at https://bugs.launchpad.net/qemu/+bug/1494350,
> > it is possible to have vcpu->arch.st.last_steal initialized
> > from a thread other than vcpu thread, say the iothread, via
> > KVM_SET_MSRS.
> >
> > Which can cause an overflow later (when subtracting from vcpu threads
> > sched_info.run_delay).
> >
> > To avoid that, move steal time accumulation to vcpu entry time,
> > before copying steal time data to guest.
> >
> > Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
>
> Reviewed-by: David Matlack <dmatlack@google.com>
Applied to kvm/queue. Thanks Marcelo, and thanks David for the review.
Paolo
prev parent reply other threads:[~2015-10-16 8:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-14 22:33 [PATCH] KVM: x86: move steal time initialization to vcpu entry time Marcelo Tosatti
2015-10-15 17:10 ` David Matlack
2015-10-16 8:34 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5620B6AE.9020004@redhat.com \
--to=pbonzini@redhat.com \
--cc=amit.shah@redhat.com \
--cc=dgilbert@redhat.com \
--cc=dmatlack@google.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).