From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH] KVM: x86: move steal time initialization to vcpu entry
 time
Date: Fri, 16 Oct 2015 10:34:54 +0200
Message-ID: <5620B6AE.9020004@redhat.com>
References: <20151014223309.GA13900@amt.cnet>
 <CALzav=fa+EJJpzWj9kQLbgG2Z9vKHqSfB==RhP0bvA5j2_QUMQ@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: kvm list <kvm@vger.kernel.org>, Rik van Riel <riel@redhat.com>,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
	Amit Shah <amit.shah@redhat.com>
To: David Matlack <dmatlack@google.com>,
	Marcelo Tosatti <mtosatti@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:54335 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751334AbbJPIe7 (ORCPT <rfc822;kvm@vger.kernel.org>);
	Fri, 16 Oct 2015 04:34:59 -0400
In-Reply-To: <CALzav=fa+EJJpzWj9kQLbgG2Z9vKHqSfB==RhP0bvA5j2_QUMQ@mail.gmail.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>



On 15/10/2015 19:10, David Matlack wrote:
> > As reported at https://bugs.launchpad.net/qemu/+bug/1494350,
> > it is possible to have vcpu->arch.st.last_steal initialized
> > from a thread other than vcpu thread, say the iothread, via
> > KVM_SET_MSRS.
> >
> > Which can cause an overflow later (when subtracting from vcpu threads
> > sched_info.run_delay).
> >
> > To avoid that, move steal time accumulation to vcpu entry time,
> > before copying steal time data to guest.
> >
> > Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
> 
> Reviewed-by: David Matlack <dmatlack@google.com>

Applied to kvm/queue.  Thanks Marcelo, and thanks David for the review.

Paolo