From mboxrd@z Thu Jan 1 00:00:00 1970 From: Xiao Guangrong Subject: Re: [PATCH v4 23/33] nvdimm acpi: init the address region used by NVDIMM ACPI Date: Mon, 19 Oct 2015 11:58:35 +0800 Message-ID: <56246A6B.6080904@linux.intel.com> References: <1445216059-88521-1-git-send-email-guangrong.xiao@linux.intel.com> <1445216059-88521-24-git-send-email-guangrong.xiao@linux.intel.com> <20151018171551.GA9847@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: pbonzini@redhat.com, imammedo@redhat.com, gleb@kernel.org, mtosatti@redhat.com, stefanha@redhat.com, rth@twiddle.net, ehabkost@redhat.com, dan.j.williams@intel.com, kvm@vger.kernel.org, qemu-devel@nongnu.org To: "Michael S. Tsirkin" Return-path: Received: from mga02.intel.com ([134.134.136.20]:2099 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750736AbbJSEE7 (ORCPT ); Mon, 19 Oct 2015 00:04:59 -0400 In-Reply-To: <20151018171551.GA9847@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 10/19/2015 01:15 AM, Michael S. Tsirkin wrote: > On Mon, Oct 19, 2015 at 08:54:09AM +0800, Xiao Guangrong wrote: >> +typedef struct nfit_spa nfit_spa; > > There are still multiple coding style violations. Pls fix all code t= o > match coding style. I commented on this before. > Er, i thought what you disliked is just function names... Now I know i was misunderstanding it and sorry for wasting your time on it. I will change all structs in this patch that=EF=BC=9A struct nfit_spa =EF=BC=8D> struct nvdimm_nfit_spa struct nfit_memdev -> struct nvdimm_nfit_memdev struct nfit_dcr nfit_dcr -> struct nvdimm_nfit_dcr nfit_dcr; and also copy the spec reference from where these struct was used to where these struct was defined.