From mboxrd@z Thu Jan 1 00:00:00 1970 From: Xiao Guangrong Subject: Re: [PATCH v3 26/32] nvdimm: save arg3 for NVDIMM device _DSM method Date: Mon, 19 Oct 2015 15:51:26 +0800 Message-ID: <5624A0FE.8050007@linux.intel.com> References: <1444535584-18220-1-git-send-email-guangrong.xiao@linux.intel.com> <1444535584-18220-27-git-send-email-guangrong.xiao@linux.intel.com> <20151019095026-mutt-send-email-mst@redhat.com> <56249854.2090007@linux.intel.com> <20151019104112-mutt-send-email-mst@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: pbonzini@redhat.com, imammedo@redhat.com, gleb@kernel.org, mtosatti@redhat.com, stefanha@redhat.com, rth@twiddle.net, ehabkost@redhat.com, dan.j.williams@intel.com, kvm@vger.kernel.org, qemu-devel@nongnu.org To: "Michael S. Tsirkin" Return-path: Received: from mga14.intel.com ([192.55.52.115]:16638 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750759AbbJSH5t (ORCPT ); Mon, 19 Oct 2015 03:57:49 -0400 In-Reply-To: <20151019104112-mutt-send-email-mst@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 10/19/2015 03:47 PM, Michael S. Tsirkin wrote: >>> aml_arg(3) is used many times below. >>> Pls give it a name that makes sense (not arg3! what is it for?) >>> >> >> Er. aml_arg(3) is just the fourth parameter of _DSM method. Will add some >> comments: >> >> /* >> * The fourth parameter (Arg3) of _DMS is a package which contains a buffer, the >> * layout of the buffer is specified by UUID (Arg0), Revision ID (Arg1) and >> * Function Index (Arg2) which are documented in the DSM specification. >> */ >> >>>> + aml_int(1)))); >>> >>> Pls document AML constants used. >>> Like this: >>> >>> ifctx = aml_if(aml_and(aml_equal(aml_object_type(aml_arg(3)), >>> aml_int(4 /* 4 - Package */) ), >>> aml_equal(aml_sizeof(aml_arg(3)), >>> aml_int(1)))); >>> >>>> + { >>>> + /* Local0 = Index(Arg3, 0) */ >>>> + aml_append(ifctx, aml_store(aml_index(aml_arg(3), aml_int(0)), >>>> + aml_local(0))); >>>> + /* Local3 = DeRefOf(Local0) */ >>>> + aml_append(ifctx, aml_store(aml_derefof(aml_local(0)), >>>> + aml_local(3))); >>>> + /* ARG3 = Local3 */ >>>> + aml_append(ifctx, aml_store(aml_local(3), aml_name("ARG3"))); >>> >>> This isn't a good way to comment things: you are >>> just adding ASL before the equivalent C. >>> Pls document what's going on. >>> >> >> Okay... i just thought C is little readable than AML. Will change the comment >> to: >> >> /* fetch buffer from the package (Arg3) and store it to DSM memory. */ >> >> Thanks. > > You can use variables to make the logic clear. E.g.: > > Aml *pckg = aml_arg(3); > Aml *pckg_idx = aml_local(0); > Aml *pckg_buf = aml_local(3); > > aml_append(ifctx, aml_store(aml_index(pckg, aml_int(0)), pckg_idx); > aml_append(ifctx, aml_store(aml_derefof(pckg_idx), pckg_buf)); > > > This is also better than repeating aml_arg(3) many times. > Indeed, it's more clearer now. Thanks for your review and really appreciate for your patience, Michael!