From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH v2] kvm: Allow the Hyper-V vendor ID to be specified Date: Mon, 19 Oct 2015 10:08:42 +0200 Message-ID: <5624A50A.1040107@redhat.com> References: <20151016153356.28104.48612.stgit@gimli.home> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: imammedo@redhat.com To: Alex Williamson , qemu-devel@nongnu.org, kvm@vger.kernel.org Return-path: In-Reply-To: <20151016153356.28104.48612.stgit@gimli.home> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org List-Id: kvm.vger.kernel.org On 16/10/2015 17:38, Alex Williamson wrote: > According to Microsoft documentation, the signature in the standard > hypervisor CPUID leaf at 0x40000000 identifies the Vendor ID and is > for reporting and diagnostic purposes only. We can therefore allow > the user to change it to whatever they want, within the 12 character > limit. Add a new hyperv-vendor-id option to the -cpu flag to allow > for this, ex: > > -cpu host,hv_time,hv_vendor_id=KeenlyKVM > > Link: http://msdn.microsoft.com/library/windows/hardware/hh975392 > Signed-off-by: Alex Williamson > --- > > v2: Replace abort() with truncating the string, error report updated > > Igor also had the idea of creating a DEFINE_PROP_STRING_LEN property > where we could enforce the length earlier in the parameter checking. > If we like that idea, we probably need to do it first since we don't > want to switch from truncating to erroring between releases. I can > work on that if preferred. Thanks, I applied this one, because the truncation matches what is done in other places (ACPI tables, SCSI product/vendor, etc.) Paolo