From mboxrd@z Thu Jan  1 00:00:00 1970
From: Xiao Guangrong <guangrong.xiao@linux.intel.com>
Subject: Re: [PATCH v3 22/32] nvdimm: init the address region used by NVDIMM
 ACPI
Date: Tue, 20 Oct 2015 01:54:12 +0800
Message-ID: <56252E44.9050901@linux.intel.com>
References: <1444535584-18220-1-git-send-email-guangrong.xiao@linux.intel.com>
 <1444535584-18220-23-git-send-email-guangrong.xiao@linux.intel.com>
 <20151019095612-mutt-send-email-mst@redhat.com>
 <20151019111836.2e830737@igors-macbook-pro.local>
 <20151019132401-mutt-send-email-mst@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: pbonzini@redhat.com, gleb@kernel.org, mtosatti@redhat.com,
	stefanha@redhat.com, rth@twiddle.net, ehabkost@redhat.com,
	dan.j.williams@intel.com, kvm@vger.kernel.org,
	qemu-devel@nongnu.org
To: "Michael S. Tsirkin" <mst@redhat.com>,
	Igor Mammedov <imammedo@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mga09.intel.com ([134.134.136.24]:4681 "EHLO mga09.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1754445AbbJSSAe (ORCPT <rfc822;kvm@vger.kernel.org>);
	Mon, 19 Oct 2015 14:00:34 -0400
In-Reply-To: <20151019132401-mutt-send-email-mst@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>



On 10/19/2015 06:25 PM, Michael S. Tsirkin wrote:
> On Mon, Oct 19, 2015 at 11:18:36AM +0200, Igor Mammedov wrote:
>> On Mon, 19 Oct 2015 09:56:12 +0300
>> "Michael S. Tsirkin" <mst@redhat.com> wrote:
>>
>>> On Sun, Oct 11, 2015 at 11:52:54AM +0800, Xiao Guangrong wrote:
>> [...]
>>>> diff --git a/include/hw/mem/nvdimm.h b/include/hw/mem/nvdimm.h
>>>> index f6bd2c4..aa95961 100644
>>>> --- a/include/hw/mem/nvdimm.h
>>>> +++ b/include/hw/mem/nvdimm.h
>>>> @@ -15,6 +15,10 @@
>>>>
>>>>   #include "hw/mem/dimm.h"
>>>>
>>>> +/* Memory region 0xFF00000 ~ 0xFFF00000 is reserved for NVDIMM
>>>> ACPI. */ +#define NVDIMM_ACPI_MEM_BASE   0xFF000000ULL
>> Michael,
>>
>> If it's ok to map control RAM region directly from QEMU at arbitrary
>> location
>
> It's a fair question. Where is it reserved? In which spec?
>

The region 0xFF00000 ~ 0xFFF00000 is just reserved for vDSM implementation,
it is not required by spec.