From mboxrd@z Thu Jan  1 00:00:00 1970
From: Xiao Guangrong <guangrong.xiao@linux.intel.com>
Subject: Re: [PATCH v7 11/35] util: introduce
	qemu_file_getlength()
Date: Wed, 4 Nov 2015 11:17:09 +0800
Message-ID: <563978B5.5070803@linux.intel.com>
References: <1446455617-129562-1-git-send-email-guangrong.xiao@linux.intel.com>
	<1446455617-129562-12-git-send-email-guangrong.xiao@linux.intel.com>
	<20151103232151.GH4180@thinpad.lan.raisama.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: vsementsov@virtuozzo.com, kvm@vger.kernel.org, mst@redhat.com,
	gleb@kernel.org, mtosatti@redhat.com, qemu-devel@nongnu.org,
	stefanha@redhat.com, imammedo@redhat.com, pbonzini@redhat.com,
	dan.j.williams@intel.com, rth@twiddle.net
To: Eduardo Habkost <ehabkost@redhat.com>
Return-path: <qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org>
In-Reply-To: <20151103232151.GH4180@thinpad.lan.raisama.net>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org
Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org
List-Id: kvm.vger.kernel.org



On 11/04/2015 07:21 AM, Eduardo Habkost wrote:
> On Mon, Nov 02, 2015 at 05:13:13PM +0800, Xiao Guangrong wrote:
> [...]
>> +size_t qemu_file_getlength(const char *file, Error **errp)
>> +{
>> +    int64_t size;
> [...]
>> +    return size;
>
> Can you guarantee that SIZE_MAX >= INT64_MAX on all platforms supported
> by QEMU?
>

Actually, this function is abstracted from the common function, raw_getlength(),
in raw-posix.c whose return value is int64_t.

And i think int64_t is large enough for block devices.