Re: [v2] KVM: VMX: Fix commit which broke PML

[Paolo Bonzini <pbonzini@redhat.com>]

On 05/11/2015 03:04, Kai Huang wrote:
> 
> Thanks for applying! I am really sorry that I forgot to delete the line
> that clears SECONDARY_EXEC_ENABLE_PML bit in vmx_disable_pml, which is
> renamed to vmx_destroy_pml_buffer now.
> It won't impact functionality but to make the function consistent, would
> you also do below? Sorry for such negligence!
> 
> diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
> index 89f4fa2..ef4ca76 100644
> --- a/arch/x86/kvm/vmx.c
> +++ b/arch/x86/kvm/vmx.c
> @@ -7826,8 +7826,6 @@ static void vmx_destroy_pml_buffer(struct vcpu_vmx
> *vmx)
>         ASSERT(vmx->pml_pg);
>         __free_page(vmx->pml_pg);
>         vmx->pml_pg = NULL;
> -
> -       vmcs_clear_bits(SECONDARY_VM_EXEC_CONTROL,
> SECONDARY_EXEC_ENABLE_PML);
>  }

No problem.  I haven't yet pushed to kvm/next, so I can change this commit.

Thanks for the quick response.

Paolo