From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?UTF-8?Q?Andreas_F=c3=a4rber?= <afaerber@suse.de>
Subject: Re: [PATCH 1/3] qemu, pkeys: add pkeys support for qemu cpuid
 handling
Date: Mon, 9 Nov 2015 16:19:12 +0100
Message-ID: <5640B970.8020803@suse.de>
References: <1447070134-4324-1-git-send-email-huaitong.han@intel.com>
 <1447070134-4324-2-git-send-email-huaitong.han@intel.com>
 <56409064.6040609@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: QUOTED-PRINTABLE
Cc: Paolo Bonzini <pbonzini@redhat.com>, rth@twiddle.net,
	ehabkost@redhat.com, qemu-devel@nongnu.org, kvm@vger.kernel.org
To: Huaitong Han <huaitong.han@intel.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx2.suse.de ([195.135.220.15]:52988 "EHLO mx2.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751213AbbKIPTP (ORCPT <rfc822;kvm@vger.kernel.org>);
	Mon, 9 Nov 2015 10:19:15 -0500
In-Reply-To: <56409064.6040609@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Am 09.11.2015 um 13:24 schrieb Paolo Bonzini:
> On 09/11/2015 12:55, Huaitong Han wrote:
>> @@ -351,6 +362,7 @@ static const char *cpuid_6_feature_name[] =3D {
>>            CPUID_7_0_EBX_FSGSBASE, CPUID_7_0_EBX_HLE, CPUID_7_0_EBX_=
AVX2,
>>            CPUID_7_0_EBX_ERMS, CPUID_7_0_EBX_INVPCID, CPUID_7_0_EBX_=
RTM,
>>            CPUID_7_0_EBX_RDSEED */
>> +#define TCG_7_0_ECX_FEATURES (CPUID_7_0_ECX_PKU | CPUID_7_0_ECX_OSP=
KE)
>=20
> This should be zero.  Apart from this detail, the QEMU parts look goo=
d.

=2E..except for the subjects, which should be "target-i386: add pkeys
support for cpuid handling" etc. - no need to put qemu into a QEMU
commit subject, especially not twice.

Regards,
Andreas

--=20
SUSE Linux GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Felix Imend=F6rffer, Jane Smithard, Graham Norton; HRB 21284 (AG N=FC=
rnberg)