From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Huth Subject: Re: [kvm-unit-tests PATCH v2 02/19] trivial: lib: fail hard on failed mallocs Date: Mon, 9 Nov 2015 21:55:50 +0100 Message-ID: <56410856.8040502@redhat.com> References: <1446769483-21586-3-git-send-email-drjones@redhat.com> <1447102433-20322-1-git-send-email-drjones@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: alex.bennee@linaro.org, cov@codeaurora.org To: Andrew Jones , pbonzini@redhat.com, kvm@vger.kernel.org Return-path: Received: from mx1.redhat.com ([209.132.183.28]:56565 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750819AbbKIUzx (ORCPT ); Mon, 9 Nov 2015 15:55:53 -0500 In-Reply-To: <1447102433-20322-1-git-send-email-drjones@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 09/11/15 21:53, Andrew Jones wrote: > It's pretty safe to not even bother checking for NULL when > using malloc and friends, but if we do check, then fail > hard. > > Signed-off-by: Andrew Jones > --- > v2: no code in asserts [Thomas Huth] > > lib/virtio-mmio.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/lib/virtio-mmio.c b/lib/virtio-mmio.c > index 043832299174e..5ccbd193a264a 100644 > --- a/lib/virtio-mmio.c > +++ b/lib/virtio-mmio.c > @@ -54,8 +54,7 @@ static struct virtqueue *vm_setup_vq(struct virtio_device *vdev, > > vq = calloc(1, sizeof(*vq)); > queue = memalign(PAGE_SIZE, VIRTIO_MMIO_QUEUE_SIZE_MIN); > - if (!vq || !queue) > - return NULL; > + assert(vq && queue); > > writel(index, vm_dev->base + VIRTIO_MMIO_QUEUE_SEL); > > @@ -162,8 +161,7 @@ static struct virtio_device *virtio_mmio_dt_bind(u32 devid) > return NULL; > > vm_dev = calloc(1, sizeof(*vm_dev)); > - if (!vm_dev) > - return NULL; > + assert(vm_dev != NULL); > > vm_dev->base = info.base; > vm_device_init(vm_dev); Reviewed-by: Thomas Huth