From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [kvm-unit-tests PATCH 01/18] makefiles: use bash
Date: Tue, 10 Nov 2015 17:22:41 +0100
Message-ID: <564219D1.1090604@redhat.com>
References: <1446769483-21586-1-git-send-email-drjones@redhat.com>
 <1446769483-21586-2-git-send-email-drjones@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Cc: alex.bennee@linaro.org, cov@codeaurora.org
To: Andrew Jones <drjones@redhat.com>, kvm@vger.kernel.org
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:51525 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751601AbbKJQWu (ORCPT <rfc822;kvm@vger.kernel.org>);
	Tue, 10 Nov 2015 11:22:50 -0500
In-Reply-To: <1446769483-21586-2-git-send-email-drjones@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>



On 06/11/2015 01:24, Andrew Jones wrote:
> Use bash in the makefiles, like we do in the scripts. Without
> this some platforms using dash fail to execute make targets
> that use bash-isms.
> 
> Signed-off-by: Andrew Jones <drjones@redhat.com>
> ---
>  Makefile | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Makefile b/Makefile
> index 0d5933474cd8c..3e60b4f8e4a57 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1,4 +1,6 @@
>  
> +SHELL := /bin/bash
> +
>  ifeq ($(wildcard config.mak),)
>  $(error run ./configure first. See ./configure -h)
>  endif
> 

Which bash-isms are actually present?

Paolo