From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [kvm-unit-tests PATCH 01/18] makefiles: use bash Date: Tue, 10 Nov 2015 17:48:43 +0100 Message-ID: <56421FEB.3090000@redhat.com> References: <1446769483-21586-1-git-send-email-drjones@redhat.com> <1446769483-21586-2-git-send-email-drjones@redhat.com> <564219D1.1090604@redhat.com> <20151110163723.GC3452@hawk.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, alex.bennee@linaro.org, cov@codeaurora.org To: Andrew Jones Return-path: Received: from mx1.redhat.com ([209.132.183.28]:53020 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754244AbbKJQst (ORCPT ); Tue, 10 Nov 2015 11:48:49 -0500 In-Reply-To: <20151110163723.GC3452@hawk.localdomain> Sender: kvm-owner@vger.kernel.org List-ID: On 10/11/2015 17:37, Andrew Jones wrote: > On Tue, Nov 10, 2015 at 05:22:41PM +0100, Paolo Bonzini wrote: >> >> >> On 06/11/2015 01:24, Andrew Jones wrote: >>> Use bash in the makefiles, like we do in the scripts. Without >>> this some platforms using dash fail to execute make targets >>> that use bash-isms. >>> >>> Signed-off-by: Andrew Jones >>> --- >>> Makefile | 2 ++ >>> 1 file changed, 2 insertions(+) >>> >>> diff --git a/Makefile b/Makefile >>> index 0d5933474cd8c..3e60b4f8e4a57 100644 >>> --- a/Makefile >>> +++ b/Makefile >>> @@ -1,4 +1,6 @@ >>> >>> +SHELL := /bin/bash >>> + >>> ifeq ($(wildcard config.mak),) >>> $(error run ./configure first. See ./configure -h) >>> endif >>> >> >> Which bash-isms are actually present? > > config/config-arm-common.mak has $(RM) $(TEST_DIR)/*.{o,flat,elf,map} ... > > I could certainly change that one, and that may be the only one... But, > we require bash for other scripts anyway, so I think requiring make to > use it is reasonable. One is enough to apply the patch. :) Thanks, Paolo