From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH 00/10 V2] KVM: x86: MMU: Clean up x86's mmu code for future work Date: Thu, 12 Nov 2015 13:08:08 +0100 Message-ID: <56448128.1090600@redhat.com> References: <20151112204849.ba920599a8426d7196a0df73@lab.ntt.co.jp> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Marcelo Tosatti To: Takuya Yoshikawa Return-path: Received: from mx1.redhat.com ([209.132.183.28]:39254 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754403AbbKLMIM (ORCPT ); Thu, 12 Nov 2015 07:08:12 -0500 In-Reply-To: <20151112204849.ba920599a8426d7196a0df73@lab.ntt.co.jp> Sender: kvm-owner@vger.kernel.org List-ID: On 12/11/2015 12:48, Takuya Yoshikawa wrote: > v1->v2: > Patch 5 and 7 are added based on Paolo's suggestions. > Patch 8-10 are new. > > Patch 1/2/3/4: no change. > Patch 5: Needed a bit more work than I had expected. > Patch 6: Removed extra comment of v1 (patch 5 made it inappropriate). > Patch 7: As expected, many places needed to be converted. > Patch 8: This is new, but only a small change. > > Patch 9: Kind of an RFC (though I have checked it to some extent). > Following two places need to be carefully checked: > - in kvm_mmu_get_page: "if (!direct)" block after kvm_mmu_alloc_page() > - in FNAME(fetch): "if (FNAME(gpte_changed)(vcpu, gw, it.level - 1))" case > Patch 10: Trivial cleanup, assuming that patch 9 is correct. > > > In summary: patch 1-7 is the result of updating v1 based on the suggestions. > Although patch 5 does not look so nice than expected, this is the most > conservative approach, and patch 8-10 try to alleviate the sadness. If it works, it's actually better than what we have now. I'll review it in a few days. Marcelo, can you look at this as well? You are still king of MMU. :) Thanks, Paolo