From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: Shut up unhandled MSR warnings Date: Thu, 12 Nov 2015 13:28:16 +0100 Message-ID: <564485E0.9040902@redhat.com> References: <20151112101317.GA3649@pd.tnic> <56446AFD.4030800@redhat.com> <20151112105958.GA3838@pd.tnic> <20151112121613.GC3838@pd.tnic> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: =?UTF-8?B?SsO2cmcgUsO2ZGVs?= , kvm ML , lkml To: Borislav Petkov Return-path: Received: from mx1.redhat.com ([209.132.183.28]:51869 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754332AbbKLM2U (ORCPT ); Thu, 12 Nov 2015 07:28:20 -0500 In-Reply-To: <20151112121613.GC3838@pd.tnic> Sender: kvm-owner@vger.kernel.org List-ID: On 12/11/2015 13:16, Borislav Petkov wrote: >>> > > Yes, see guest_cpuid_has_* for an example of reading the CPUID values. >>> > > >>> > > But if it's defined for _all_ models starting at family 21, we can just >>> > > do it unconditionally. >> > >> > The thing is, those bits are Reserved again on the next family 22. Lemme >> > take a look at guest_cpuid_has_* and see how ugly it gets. > > Ok, I see there's guest_cpuid_is_amd() but I'd need also family and model. > > How about adding also > > guest_cpuid_family(), guest_cpuid_model(), guest_cpuid_stepping()? Those > could be quite useful in other contexts maybe. Sure, that's what I meant by "for an example". :) Paolo