From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH 09/10 RFC] KVM: x86: MMU: Move parent_pte handling from kvm_mmu_get_page() to link_shadow_page() Date: Thu, 12 Nov 2015 18:03:28 +0100 Message-ID: <5644C660.6030606@redhat.com> References: <20151112204849.ba920599a8426d7196a0df73@lab.ntt.co.jp> <20151112205656.33f23effece7e6914c3e2646@lab.ntt.co.jp> <5644A1CE.1040906@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org To: Takuya Yoshikawa Return-path: In-Reply-To: <5644A1CE.1040906@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On 12/11/2015 15:27, Paolo Bonzini wrote: > Here I think you can remove completely the > > if (sp) > kvm_mmu_put_page(sp, it.sptep); > > later in FNAME(fetch). Apart from this nit, it's okay. Removing this is of course not possible anymore if the other suggestion works out. Paolo