From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH 05/10] KVM: x86: MMU: Use for_each_rmap_spte macro instead
 of pte_list_walk()
Date: Tue, 17 Nov 2015 18:58:42 +0100
Message-ID: <564B6AD2.1030905@redhat.com>
References: <20151112204849.ba920599a8426d7196a0df73@lab.ntt.co.jp>
 <20151112205245.6bd773737cfa78422dac5a79@lab.ntt.co.jp>
 <20151113214727.GA29103@amt.cnet> <20151114092047.GA25627@amt.cnet>
 <564944A3.5080005@lab.ntt.co.jp>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org
To: Takuya Yoshikawa <yoshikawa_takuya_b1@lab.ntt.co.jp>,
	Marcelo Tosatti <mtosatti@redhat.com>
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <564944A3.5080005@lab.ntt.co.jp>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: kvm.vger.kernel.org



On 16/11/2015 03:51, Takuya Yoshikawa wrote:
> What kvm_mmu_mark_parents_unsync() does is:
> 
>   for each p_i in sp->parent_ptes rmap chain
>     mark_unsync(p_i);
> 
> Then, mark_unsync() finds the parent sp including that p_i to
> set ->unsync_child_bitmap and increment ->unsync_children if
> necessary.  It may also call kvm_mmu_mark_parents_unsync()
> recursively.

I agree.  sp->parent_ptes goes up one level from sp;
kvm_mmu_mark_parents_unsync(sp) visits the level above sp, while
mark_unsync(sp) visit sp and all the levels above it.

Calling mark_unsync(parent_pte) is enough to complete the visit, after
kvm_mmu_mark_parents_unsync has already processed the level above sp.

Paolo