From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH 07/10] KVM: x86: MMU: Encapsulate the type of rmap-chain head in a new struct Date: Wed, 18 Nov 2015 10:09:00 +0100 Message-ID: <564C402C.8030503@redhat.com> References: <20151112204849.ba920599a8426d7196a0df73@lab.ntt.co.jp> <20151112205503.82a69e2309928a854e25f75f@lab.ntt.co.jp> <564BEEAA.4080101@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org To: Xiao Guangrong , Takuya Yoshikawa Return-path: In-Reply-To: <564BEEAA.4080101@linux.intel.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On 18/11/2015 04:21, Xiao Guangrong wrote: > > > On 11/12/2015 07:55 PM, Takuya Yoshikawa wrote: >> @@ -1720,7 +1724,7 @@ static struct kvm_mmu_page >> *kvm_mmu_alloc_page(struct kvm_vcpu *vcpu, >> * this feature. See the comments in kvm_zap_obsolete_pages(). >> */ >> list_add(&sp->link, &vcpu->kvm->arch.active_mmu_pages); >> - sp->parent_ptes = 0; >> + sp->parent_ptes.val = 0; > > The sp is allocated from kmem_cache_zalloc() so explicitly initialize it > to zero is not needed. Right, but it should be a separate patch. Takuya, since you are going to send another version of this series, can you also: 1) move this patch either to the beginning or to the end 2) include "KVM: x86: always set accessed bit in shadow PTEs", also near the beginning of the series? Thanks! Paolo