From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christian Borntraeger Subject: Re: [PATCH 1/4] KVM: Provide function for VCPU lookup by id Date: Thu, 19 Nov 2015 14:23:15 +0100 Message-ID: <564DCD43.8080108@de.ibm.com> References: <1447922251-54261-1-git-send-email-borntraeger@de.ibm.com> <1447922251-54261-2-git-send-email-borntraeger@de.ibm.com> <564DBC88.5020508@redhat.com> <20151119135527.77ab6fda@thinkpad-w530> <564DCAED.8020805@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: Alexander Graf , Paul Mackerras , KVM , Cornelia Huck , Jens Freimann , linux-s390 , kvm-ppc@vger.kernel.org To: Paolo Bonzini , David Hildenbrand , Thomas Huth Return-path: Received: from e06smtp15.uk.ibm.com ([195.75.94.111]:46032 "EHLO e06smtp15.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751396AbbKSNXV (ORCPT ); Thu, 19 Nov 2015 08:23:21 -0500 Received: from localhost by e06smtp15.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 19 Nov 2015 13:23:20 -0000 In-Reply-To: <564DCAED.8020805@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 11/19/2015 02:13 PM, Paolo Bonzini wrote: > > > On 19/11/2015 13:55, David Hildenbrand wrote: >>>> >>>> I'm pretty sure this will cause confusion in the future! >>>> ==> Could you maybe name the new function something like >>>> "kvm_lookup_vcpu_by_id" or "kvm_get_vcpu_by_id" instead? >> Had that in a previous version but decided to name it that way ... hmm ... >> other opinions? > > Having _by_id at the end of the name makes sense indeed. David, I will fix up the function name myself to kvm_get_vcpu_by_id. Ok?