From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marc Zyngier <marc.zyngier@arm.com>
Subject: Re: [PATCH 04/21] arm64: KVM: Implement vgic-v3 save/restore
Date: Fri, 20 Nov 2015 17:41:53 +0000
Message-ID: <564F5B61.8000701@arm.com>
References: <1447679519-17888-1-git-send-email-marc.zyngier@arm.com> <1447679519-17888-5-git-send-email-marc.zyngier@arm.com> <20151120164851.GB24960@linaro.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Cc: Christoffer Dall <christoffer.dall@linaro.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Catalin Marinas <catalin.marinas@arm.com>, kvm@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu
To: Steve Capper <steve.capper@linaro.org>
Return-path: <kvm-owner@vger.kernel.org>
Received: from foss.arm.com ([217.140.101.70]:47974 "EHLO foss.arm.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1163157AbbKTRl5 (ORCPT <rfc822;kvm@vger.kernel.org>);
	Fri, 20 Nov 2015 12:41:57 -0500
In-Reply-To: <20151120164851.GB24960@linaro.org>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On 20/11/15 16:48, Steve Capper wrote:
> On Mon, Nov 16, 2015 at 01:11:42PM +0000, Marc Zyngier wrote:
>> Implement the vgic-v3 save restore as a direct translation of
>> the assembly code version.
> 
> I think there's a couple of typos below Marc.

[...]

>> +	case 10:
>> +		cpu_if->vgic_lr[LR_OFFSET(19)] = read_gicreg(ICH_LR10_EL2);
> 
> LR_OFFSET(10) ?

Memory corruption, here we come!!!! ;-)

Thanks, I'll fix those!

	M.
-- 
Jazz is not dead. It just smells funny...