From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH 1/3] target-i386: kvm: Abort if MCE bank count is not
 supported by host
Date: Wed, 25 Nov 2015 18:30:20 +0100
Message-ID: <5655F02C.5090306@redhat.com>
References: <1448466589-9407-1-git-send-email-ehabkost@redhat.com>
 <1448466589-9407-2-git-send-email-ehabkost@redhat.com>
 <5655E5EE.8060906@redhat.com>
 <20151125172617.GS23717@thinpad.lan.raisama.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Cc: qemu-devel@nongnu.org, Marcelo Tosatti <mtosatti@redhat.com>,
	kvm@vger.kernel.org, ying.huang@intel.com,
	Borislav Petkov <bp@alien8.de>,
	=?UTF-8?Q?Andreas_F=c3=a4rber?= <afaerber@suse.de>,
	Richard Henderson <rth@twiddle.net>
To: Eduardo Habkost <ehabkost@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:45256 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752218AbbKYRa0 (ORCPT <rfc822;kvm@vger.kernel.org>);
	Wed, 25 Nov 2015 12:30:26 -0500
In-Reply-To: <20151125172617.GS23717@thinpad.lan.raisama.net>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>



On 25/11/2015 18:26, Eduardo Habkost wrote:
>> > Yoda conditions?
>> > 
>> >         if (banks < MCE_BANKS_DEF) {
>> >             error_report("kvm: Unsupported MCE bank count (QEMU = %d, KVM = %d)",
>> >                          MCE_BANKS_DEF, banks);
> This was on purpose, because MCE_BANKS_DEF is replaced by
> (env->mcg_caps & MCG_CAPS_COUNT_MASK) in the next patch.

Yeah, I noticed it later.

Paolo