From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH 3/3] target-i386: kvm: Print warning when clearing mcg_cap
 bits
Date: Wed, 25 Nov 2015 18:30:32 +0100
Message-ID: <5655F038.50101@redhat.com>
References: <1448466589-9407-1-git-send-email-ehabkost@redhat.com>
 <1448466589-9407-4-git-send-email-ehabkost@redhat.com>
 <5655E5A0.9030009@redhat.com>
 <20151125172925.GT23717@thinpad.lan.raisama.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Cc: qemu-devel@nongnu.org, Marcelo Tosatti <mtosatti@redhat.com>,
	kvm@vger.kernel.org, ying.huang@intel.com,
	Borislav Petkov <bp@alien8.de>,
	=?UTF-8?Q?Andreas_F=c3=a4rber?= <afaerber@suse.de>,
	Richard Henderson <rth@twiddle.net>
To: Eduardo Habkost <ehabkost@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:34670 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752381AbbKYRah (ORCPT <rfc822;kvm@vger.kernel.org>);
	Wed, 25 Nov 2015 12:30:37 -0500
In-Reply-To: <20151125172925.GT23717@thinpad.lan.raisama.net>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>



On 25/11/2015 18:29, Eduardo Habkost wrote:
>>> > >  
>>> > > +        unsupported_caps = env->mcg_cap & ~(mcg_cap | MCG_CAP_BANKS_MASK);
>>> > > +        if (unsupported_caps) {
>>> > > +            error_report("warning: Unsupported MCG_CAP bits: 0x%" PRIx64 "\n",
>> > 
>> > \n should not be at end of error_report.
>> > 
>> > Fixed and applied.
> MCG_CAP_BANKS_MASK is defined by patch 2/3. Have you applied the
> whole series?

Yes, of course.

Paolo