From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marc Zyngier Subject: Re: [PATCH v2 21/21] arm64: KVM: Remove weak attributes Date: Wed, 02 Dec 2015 15:21:49 +0000 Message-ID: <565F0C8D.9010505@arm.com> References: <1448650215-15218-1-git-send-email-marc.zyngier@arm.com> <1448650215-15218-22-git-send-email-marc.zyngier@arm.com> <20151202114732.GA18376@cbox> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: =?windows-1252?Q?Alex_Benn=E9e?= , Steve Capper , Ard Biesheuvel , Mark Rutland , Catalin Marinas , linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu To: Christoffer Dall Return-path: Received: from foss.arm.com ([217.140.101.70]:43321 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755407AbbLBPVw (ORCPT ); Wed, 2 Dec 2015 10:21:52 -0500 In-Reply-To: <20151202114732.GA18376@cbox> Sender: kvm-owner@vger.kernel.org List-ID: On 02/12/15 11:47, Christoffer Dall wrote: > On Fri, Nov 27, 2015 at 06:50:15PM +0000, Marc Zyngier wrote: >> As we've now switched to the new world switch implementation, >> remove the weak attributes, as nobody is supposed to override >> it anymore. > > Why not remove the aliases and change the callers? This is likely to be a bigger patch, and it would affect the 32bit as well. So far, I'm choosing to keep things the same. Another solution would be to completely drop the aliases, and just rename the new function to have the old names. I don't mind either way. M. -- Jazz is not dead. It just smells funny...