From: Paolo Bonzini <pbonzini@redhat.com>
To: Xiao Guangrong <guangrong.xiao@gmail.com>,
Wanpeng Li <kernellwp@gmail.com>,
linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Cc: "Radim Krčmář" <rkrcmar@redhat.com>,
"Dmitry Vyukov" <dvyukov@google.com>
Subject: Re: [PATCH] KVM: X86: Fix SMRAM accessing even if VM is shutdown
Date: Thu, 8 Feb 2018 11:31:12 +0100 [thread overview]
Message-ID: <5664ca7f-f391-0301-3a0d-666b73f17b15@redhat.com> (raw)
In-Reply-To: <d21822e2-2982-7182-1d9a-be3e5b7e1553@gmail.com>
On 08/02/2018 09:57, Xiao Guangrong wrote:
>> Maybe it should return RET_PF_EMULATE, which would cause an emulation
>> failure and then an exit with KVM_EXIT_INTERNAL_ERROR.
>
> So the root cause is that a running vCPU accessing the memory whose memslot
> is being updated (met the condition KVM_MEMSLOT_INVALID is set on the its
> memslot).
>
> The normal #PF handler breaks KVM_RUN and returns -EFAULT to userspace,
> we'd better to make ept-misconfig's handler follow this style as well.
Why return -EFAULT and not attempt emulation (which will fail)?
Paolo
next prev parent reply other threads:[~2018-02-08 10:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-07 6:25 [PATCH] KVM: X86: Fix SMRAM accessing even if VM is shutdown Wanpeng Li
2018-02-07 6:41 ` Dmitry Vyukov
2018-02-07 14:16 ` Paolo Bonzini
2018-02-08 7:35 ` Wanpeng Li
2018-02-08 8:57 ` Xiao Guangrong
2018-02-08 10:31 ` Paolo Bonzini [this message]
2018-02-09 3:22 ` Xiao Guangrong
2018-02-09 12:42 ` Paolo Bonzini
2018-02-11 3:20 ` Xiao Guangrong
2018-02-11 8:56 ` Wanpeng Li
2018-02-11 10:57 ` Wanpeng Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5664ca7f-f391-0301-3a0d-666b73f17b15@redhat.com \
--to=pbonzini@redhat.com \
--cc=dvyukov@google.com \
--cc=guangrong.xiao@gmail.com \
--cc=kernellwp@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rkrcmar@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).