From: Xiao Guangrong <guangrong.xiao@linux.intel.com>
To: Kai Huang <kai.huang@linux.intel.com>, pbonzini@redhat.com
Cc: gleb@kernel.org, mtosatti@redhat.com, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 09/11] KVM: MMU: simplify mmu_need_write_protect
Date: Tue, 15 Dec 2015 17:26:49 +0800 [thread overview]
Message-ID: <566FDCD9.6080303@linux.intel.com> (raw)
In-Reply-To: <566FD39B.6080200@linux.intel.com>
On 12/15/2015 04:47 PM, Kai Huang wrote:
>> A further thinking is can we move it to mmu_need_write_protect? Passing can_unsync as parameter to
>> kvm_unsync_pages sounds a little bit odd.
>>
>>> +
>>> if (s->unsync)
>>> continue;
>>> WARN_ON(s->role.level != PT_PAGE_TABLE_LEVEL);
>> How about large page mapping? Such as if guest uses 2M mapping and its shadow is indirect, does
>> above WARN_ON still meet? As you removed the PT level check in mmu_need_write_protect.
>>
>> Thanks,
>> -Kai
> Btw I also think this patch can be merged with patch 6.
We can not as it depends on patch 8. ;)
next prev parent reply other threads:[~2015-12-15 9:26 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-30 18:26 [PATCH 00/11] KVM: x86: track guest page access Xiao Guangrong
2015-11-30 18:26 ` [PATCH 01/11] KVM: MMU: rename has_wrprotected_page to mmu_gfn_lpage_is_disallowed Xiao Guangrong
2015-11-30 18:26 ` [PATCH 02/11] KVM: MMU: introduce kvm_mmu_gfn_{allow,disallow}_lpage Xiao Guangrong
2015-11-30 18:26 ` [PATCH 03/11] KVM: MMU: introduce kvm_mmu_slot_gfn_write_protect Xiao Guangrong
2015-11-30 18:26 ` [PATCH 04/11] KVM: page track: add the framework of guest page tracking Xiao Guangrong
2015-12-15 7:06 ` Kai Huang
2015-12-15 8:46 ` Xiao Guangrong
2015-12-16 7:33 ` Kai Huang
2015-11-30 18:26 ` [PATCH 05/11] KVM: page track: introduce kvm_page_track_{add,remove}_page Xiao Guangrong
2015-12-15 7:15 ` Kai Huang
2015-12-15 7:56 ` Kai Huang
2015-11-30 18:26 ` [PATCH 06/11] KVM: MMU: let page fault handler be aware tracked page Xiao Guangrong
2015-12-15 8:11 ` Kai Huang
2015-12-15 9:03 ` Xiao Guangrong
2015-12-16 7:31 ` Kai Huang
2015-12-16 8:23 ` Xiao Guangrong
2015-11-30 18:26 ` [PATCH 07/11] KVM: page track: add notifier support Xiao Guangrong
2015-12-16 5:53 ` Jike Song
2015-12-16 6:26 ` Xiao Guangrong
2015-11-30 18:26 ` [PATCH 08/11] KVM: MMU: use page track for non-leaf shadow pages Xiao Guangrong
2015-12-15 7:52 ` Kai Huang
2015-12-15 7:59 ` Kai Huang
2015-12-15 9:10 ` Xiao Guangrong
2015-12-16 7:51 ` Kai Huang
2015-12-16 8:39 ` Xiao Guangrong
2015-12-17 2:44 ` Kai Huang
2015-12-17 4:07 ` Xiao Guangrong
2015-11-30 18:26 ` [PATCH 09/11] KVM: MMU: simplify mmu_need_write_protect Xiao Guangrong
2015-12-15 8:43 ` Kai Huang
2015-12-15 8:47 ` Kai Huang
2015-12-15 9:26 ` Xiao Guangrong [this message]
2015-12-15 9:25 ` Xiao Guangrong
2015-12-16 8:05 ` Kai Huang
2015-12-16 8:48 ` Xiao Guangrong
2015-12-17 2:51 ` Kai Huang
2015-11-30 18:26 ` [PATCH 10/11] KVM: MMU: clear write-flooding on the fast path of tracked page Xiao Guangrong
2015-11-30 18:26 ` [PATCH 11/11] KVM: MMU: apply page track notifier Xiao Guangrong
2015-12-01 10:17 ` [PATCH 00/11] KVM: x86: track guest page access Paolo Bonzini
2015-12-01 15:02 ` Andrea Arcangeli
2015-12-01 15:08 ` Paolo Bonzini
2015-12-01 17:00 ` Xiao Guangrong
2015-12-05 16:56 ` Xiao Guangrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=566FDCD9.6080303@linux.intel.com \
--to=guangrong.xiao@linux.intel.com \
--cc=gleb@kernel.org \
--cc=kai.huang@linux.intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).