Re: [PATCH 1/2] KVM: Remove unused KVM_REQ_KICK to save a bit in vcpu->requests

[Paolo Bonzini <pbonzini@redhat.com>]

On 07/01/2016 12:43, Takuya Yoshikawa wrote:
> Signed-off-by: Takuya Yoshikawa <yoshikawa_takuya_b1@lab.ntt.co.jp>
> ---
>  include/linux/kvm_host.h | 45 ++++++++++++++++++++++-----------------------
>  1 file changed, 22 insertions(+), 23 deletions(-)
> 
> diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h
> index 61c3e6c..ca9b93e 100644
> --- a/include/linux/kvm_host.h
> +++ b/include/linux/kvm_host.h
> @@ -122,29 +122,28 @@ static inline bool is_error_page(struct page *page)
>  #define KVM_REQ_UNHALT             6
>  #define KVM_REQ_MMU_SYNC           7
>  #define KVM_REQ_CLOCK_UPDATE       8
> -#define KVM_REQ_KICK               9

I'd prefer to leave just an /* unused: 9 */ here.

This patch can go in for 4.5.  Regarding the other patch,
KVM_REQ_MCLOCK_INPROGRESS is indeed not really necessary, see
http://www.spinics.net/lists/kvm/msg95944.html and the follow-up.  Were
you thinking of the same?  If so I would prefer to have some comments.

Paolo

> -#define KVM_REQ_DEACTIVATE_FPU    10
> -#define KVM_REQ_EVENT             11
> -#define KVM_REQ_APF_HALT          12
> -#define KVM_REQ_STEAL_UPDATE      13
> -#define KVM_REQ_NMI               14
> -#define KVM_REQ_PMU               15
> -#define KVM_REQ_PMI               16
> -#define KVM_REQ_WATCHDOG          17
> -#define KVM_REQ_MASTERCLOCK_UPDATE 18
> -#define KVM_REQ_MCLOCK_INPROGRESS 19
> -#define KVM_REQ_EPR_EXIT          20
> -#define KVM_REQ_SCAN_IOAPIC       21
> -#define KVM_REQ_GLOBAL_CLOCK_UPDATE 22
> -#define KVM_REQ_ENABLE_IBS        23
> -#define KVM_REQ_DISABLE_IBS       24
> -#define KVM_REQ_APIC_PAGE_RELOAD  25
> -#define KVM_REQ_SMI               26
> -#define KVM_REQ_HV_CRASH          27
> -#define KVM_REQ_IOAPIC_EOI_EXIT   28
> -#define KVM_REQ_HV_RESET          29
> -#define KVM_REQ_HV_EXIT           30
> -#define KVM_REQ_HV_STIMER         31
> +#define KVM_REQ_DEACTIVATE_FPU     9
> +#define KVM_REQ_EVENT             10
> +#define KVM_REQ_APF_HALT          11
> +#define KVM_REQ_STEAL_UPDATE      12
> +#define KVM_REQ_NMI               13
> +#define KVM_REQ_PMU               14
> +#define KVM_REQ_PMI               15
> +#define KVM_REQ_WATCHDOG          16
> +#define KVM_REQ_MASTERCLOCK_UPDATE 17
> +#define KVM_REQ_MCLOCK_INPROGRESS 18
> +#define KVM_REQ_EPR_EXIT          19
> +#define KVM_REQ_SCAN_IOAPIC       20
> +#define KVM_REQ_GLOBAL_CLOCK_UPDATE 21
> +#define KVM_REQ_ENABLE_IBS        22
> +#define KVM_REQ_DISABLE_IBS       23
> +#define KVM_REQ_APIC_PAGE_RELOAD  24
> +#define KVM_REQ_SMI               25
> +#define KVM_REQ_HV_CRASH          26
> +#define KVM_REQ_IOAPIC_EOI_EXIT   27
> +#define KVM_REQ_HV_RESET          28
> +#define KVM_REQ_HV_EXIT           29
> +#define KVM_REQ_HV_STIMER         30
>  
>  #define KVM_USERSPACE_IRQ_SOURCE_ID		0
>  #define KVM_IRQFD_RESAMPLE_IRQ_SOURCE_ID	1
>