From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH v2 3/7] kvm/x86: Hyper-V unify stimer_start() and stimer_restart() Date: Thu, 7 Jan 2016 17:40:36 +0100 Message-ID: <568E9504.30900@redhat.com> References: <1451316444-31766-1-git-send-email-asmetanin@virtuozzo.com> <1451316444-31766-4-git-send-email-asmetanin@virtuozzo.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: Gleb Natapov , Roman Kagan , "Denis V. Lunev" , qemu-devel@nongnu.org To: Andrey Smetanin , kvm@vger.kernel.org Return-path: Received: from mx1.redhat.com ([209.132.183.28]:42076 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750961AbcAGQkm (ORCPT ); Thu, 7 Jan 2016 11:40:42 -0500 In-Reply-To: <1451316444-31766-4-git-send-email-asmetanin@virtuozzo.com> Sender: kvm-owner@vger.kernel.org List-ID: On 28/12/2015 16:27, Andrey Smetanin wrote: > This will be used in future to start Hyper-V SynIC timer > in several places by one logic in one function. > > Changes v2: > * drop stimer->count == 0 check inside stimer_start() > * comment stimer_start() assumptions Can you replace comments with WARN_ON_ONCE? Paolo